From: Johannes Berg <johannes@sipsolutions.net>
To: ext-saravanan.dhanabal@nokia.com
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: RE: [PATCH] mac80211: Reschedule dynamic power save timer after wakeup
Date: Tue, 30 Mar 2010 07:33:12 +0200 [thread overview]
Message-ID: <1269927192.3927.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <04BB8F4F2843A24294353CA037CA5B58568D26B541@NOK-EUMSG-01.mgdnok.nokia.com>
On Mon, 2010-03-29 at 23:15 +0200, ext-saravanan.dhanabal@nokia.com
wrote:
> Sorry for the delay, we were checking this in driver also.
>
> The issue was due to a delay in workqueue scheduling, caused by
> msleep() inside driver. Because of this,
> last transmission happens long after the dynamic power save timer is
> scheduled. So, the difference
> between last transmission time and the time it goes to sleep is less
> than the defined PSM timeout period.
>
> I think that this patch might be considered as a workaround for such
> delays caused by driver as long as it not creating
> any other issues.
At the very least that needs to be very clearly documented in the patch,
but I'm not convinced we should be adding it. Why does the driver need
the delay, and could it maybe do it after TX? And if the driver sleeps
during the TX path how can it possibly get good performance??
johannes
next prev parent reply other threads:[~2010-03-30 5:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 15:31 [PATCH] mac80211: Reschedule dynamic power save timer after wakeup Saravanan Dhanabal
2010-03-16 21:42 ` Johannes Berg
2010-03-17 11:09 ` ext-saravanan.dhanabal
2010-03-17 16:01 ` Johannes Berg
2010-03-29 17:55 ` John W. Linville
2010-03-29 21:15 ` ext-saravanan.dhanabal
2010-03-30 5:33 ` Johannes Berg [this message]
2010-03-30 11:48 ` ext-saravanan.dhanabal
-- strict thread matches above, loose matches on Subject: below --
2010-03-16 16:46 Saravanan Dhanabal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269927192.3927.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ext-saravanan.dhanabal@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).