From: Pavel Roskin <proski@gnu.org>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath: Add a bus type field
Date: Thu, 01 Apr 2010 12:07:55 -0400 [thread overview]
Message-ID: <1270138075.4608.31.camel@mj> (raw)
In-Reply-To: <19380.10220.955466.246781@gargle.gargle.HOWL>
On Thu, 2010-04-01 at 10:28 +0530, Sujith wrote:
> This can be used to store the bus types ( AHB/PCI/USB ).
> +enum ath_bus_type {
> + ATH_PCI,
> + ATH_AHB,
> + ATH_USB,
> +};
I like the idea, but let's have ATH_BUS_PCI, ATH_BUS_AHB and
ATH_BUS_USB. This way, one would be able to grep for "ATH_BUS_" to find
all occurrences of those symbols.
There are already symbols starting with "ATH_PCI", such as
ATH_PCIE_CAP_LINK_CTRL.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-04-01 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 4:58 [PATCH 1/3] ath: Add a bus type field Sujith
2010-04-01 16:07 ` Pavel Roskin [this message]
2010-04-06 10:17 ` Sujith
2010-04-06 19:51 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270138075.4608.31.camel@mj \
--to=proski@gnu.org \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).