From: Pavel Roskin <proski@gnu.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4)
Date: Wed, 07 Apr 2010 02:29:53 -0400 [thread overview]
Message-ID: <1270621793.31184.50.camel@mj> (raw)
In-Reply-To: <1270280969-11357-4-git-send-email-sebastian@breakpoint.cc>
On Sat, 2010-04-03 at 09:49 +0200, Sebastian Andrzej Siewior wrote:
> + if (mode == CRYPT_ARC4)
> + arc4_setup_iv((struct arc4_iv *)iv,
> + template[i].key, template[i].klen);
> + else
> + ret = crypto_ablkcipher_setkey(tfm, template[i].key,
> template[i].klen);
Can we avoid those special cases? If the goal is "to make arc4
compliant with the crypto API", this looks like a step in a wrong
direction.
The same applies to many other changes in the series.
I do realize that the original arc4 is not a block cipher at all.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-04-07 6:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-03 7:49 Convert arc4 from a cipher into a block cipher Sebastian Andrzej Siewior
2010-04-03 7:49 ` [PATCH 1/7] crypto: rename arc4 Sebastian Andrzej Siewior
2010-04-03 7:49 ` [PATCH 2/7] crypto: add blkcipher implementation of ARC4 Sebastian Andrzej Siewior
2010-04-05 8:42 ` Herbert Xu
2010-04-05 17:04 ` [PATCH v2] " Sebastian Andrzej Siewior
2010-04-06 12:44 ` Herbert Xu
2010-04-06 20:30 ` Sebastian Andrzej Siewior
2010-04-07 0:31 ` Herbert Xu
2010-04-07 8:23 ` Sebastian Andrzej Siewior
2010-04-07 9:25 ` Herbert Xu
2010-04-07 6:19 ` Pavel Roskin
2010-04-07 8:29 ` Sebastian Andrzej Siewior
2010-04-07 16:31 ` Pavel Roskin
2010-04-03 7:49 ` [PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4) Sebastian Andrzej Siewior
2010-04-07 6:29 ` Pavel Roskin [this message]
2010-04-07 9:29 ` Herbert Xu
2010-04-08 7:58 ` Sebastian Andrzej Siewior
2010-04-03 7:49 ` [PATCH 4/7] net/wireless: switch lib80211_crypt_tkip from arc4 to arc4blk Sebastian Andrzej Siewior
2010-04-05 17:13 ` John W. Linville
2010-04-03 7:49 ` [PATCH 5/7] net/wireless: switch lib80211_crypt_wep " Sebastian Andrzej Siewior
2010-04-05 17:13 ` John W. Linville
2010-04-03 7:49 ` [PATCH 6/7] net/mac80211: convert wep " Sebastian Andrzej Siewior
2010-04-05 17:15 ` John W. Linville
2010-04-03 7:49 ` [PATCH 7/7] net/ppp_mppe: convert " Sebastian Andrzej Siewior
2010-04-05 20:33 ` Convert arc4 from a cipher into a block cipher Pavel Roskin
2010-04-06 0:39 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270621793.31184.50.camel@mj \
--to=proski@gnu.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).