From: Johannes Berg <johannes@sipsolutions.net>
To: Bruno Randolf <br1@einfach.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Initialize IBSS basic rates according to band
Date: Mon, 12 Apr 2010 10:10:01 +0200 [thread overview]
Message-ID: <1271059801.3877.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201004121658.09189.br1@einfach.org>
On Mon, 2010-04-12 at 16:58 +0900, Bruno Randolf wrote:
> On Monday 12 April 2010 16:41:22 you wrote:
> > On Mon, 2010-04-12 at 16:37 +0900, Bruno Randolf wrote:
> > > When we create an IBSS we are can define the basic rates according to the
> > > band in use. Previously only the B mode rates (1 and 2Mbps) were used
> > > unconditionally, which resulted in low thruput when using RTS/CTS.
> > >
> > > Also we should save the IBSS basic rates configuration when we join an
> > > IBSS.
> >
> > Again, this breaks things. If you feel this is necessary for some
> > reason, it needs to be configurable during the IBSS join by userspace.
>
> without the previous patch (which you NACKed) this is still the correct thing
> to do in B mode and will result in only 1Mbps as a basic rate. without this
> patch it is definetly wrong for A mode.
No, you don't understand. It will break _talking to_ 11b only stations
when the local station is 11g capable.
> i can see the reason why you refused the first patch, but the main problem is
> that there is no clear distiction between B and G in mac80211. there needs to
> be a way to configure B-only, G-only and BG ERP mode. i don't believe this is
> applicable to IBSS mode only... is it?
It is, as far as I can tell. And mesh maybe.
> btw: why is only 1Mbps used as a basic rate in B mode in
> set_mandatory_flags_band()? i think 2Mbps should be there as well?
Not sure, could be a bug?
> anyhow, i wouldn't mind adding something to configure this from userspace. can
> you point me to the right direction? i mean i can add something to IBSS setup
> but as i said i can't believe this is only relevant to IBSS mode.
What other modes do you think it is relevant to?
johannes
next prev parent reply other threads:[~2010-04-12 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 7:36 [PATCH 1/2] mac80211: Use G mandatory rates in 2GHz band Bruno Randolf
2010-04-12 7:37 ` [PATCH 2/2] mac80211: Initialize IBSS basic rates according to band Bruno Randolf
2010-04-12 7:41 ` Johannes Berg
2010-04-12 7:58 ` Bruno Randolf
2010-04-12 8:10 ` Johannes Berg [this message]
2010-04-12 8:34 ` Bruno Randolf
2010-04-12 8:40 ` Johannes Berg
2010-04-13 0:16 ` Bruno Randolf
2010-04-13 7:21 ` Johannes Berg
2010-04-13 7:56 ` Bruno Randolf
2010-04-12 7:39 ` [PATCH 1/2] mac80211: Use G mandatory rates in 2GHz band Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271059801.3877.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=br1@einfach.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).