Re: [PATCH 2/2] mac80211: Initialize IBSS basic rates according to band

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2010-04-12 at 17:34 +0900, Bruno Randolf wrote:

> > No, you don't understand. It will break _talking to_ 11b only stations
> > when the local station is 11g capable.
> 
> i understood that this is what you mean. note that i said *without* the other 
> patch! the first patch breaks talking to 11b only stations, true. the second 
> doesn't because:
> 
> as it is now ieee80211_mandatory_rates(local, sband->band) returns 1 (1Mbps) 
> in a 2GHz channel. which is o.k. for B only stations.

Oh ok, right.

> before we unconditionally used 3 (1Mbps, 2 Mbps) as basic rates. this clearly 
> is wrong in the 5GHz band.

No, it's fine. Look again at how this works.

> > > anyhow, i wouldn't mind adding something to configure this from
> > > userspace. can you point me to the right direction? i mean i can add
> > > something to IBSS setup but as i said i can't believe this is only
> > > relevant to IBSS mode.
> > 
> > What other modes do you think it is relevant to?
> 
> i'm not so familiar with the way STA and AP operate, but i thought that also 
> there the distiction between B, B/G and pure-G could make sense.

Not unless you want your 11g+ STA to operate in 11b-only mode.

johannes