From: Pavel Roskin <proski@gnu.org>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Grazvydas Ignotas <notasas@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] compat: fix uevent_suppress on 2.6.29 or older kernels
Date: Thu, 22 Apr 2010 16:50:59 -0400 [thread overview]
Message-ID: <1271969459.11483.3.camel@mj> (raw)
In-Reply-To: <x2l43e72e891004221333he942ee92u3ef4c6994d769694@mail.gmail.com>
On Thu, 2010-04-22 at 13:33 -0700, Luis R. Rodriguez wrote:
> On Thu, Apr 22, 2010 at 9:42 AM, Pavel Roskin <proski@gnu.org> wrote:
> > On Thu, 2010-04-22 at 09:33 -0700, Luis R. Rodriguez wrote:
> >
> >> How was this compiling for older kernels before then?
> >
> > Compiling was fine, but loading the firmware was failing sometimes. I'm
> > glad somebody figured it out. Thank you, Grazvydas!
>
> OK Applied. I'm still puzzled, if it compiled, then that means
> dev_set_uevent_suppress() was being defined somehow for older kernels.
It's wasn't defined. The function just wasn't called for older kernels.
"#if" was there; the patch added "#else".
It's a great example how simply-minded commenting out missing functions
can lead to a hard problem, a race condition.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2010-04-22 20:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 13:54 [PATCH] compat: fix uevent_suppress on 2.6.29 or older kernels Grazvydas Ignotas
2010-04-22 15:17 ` Walter Goldens
2010-04-22 16:33 ` Luis R. Rodriguez
2010-04-22 16:42 ` Pavel Roskin
2010-04-22 20:33 ` Luis R. Rodriguez
2010-04-22 20:47 ` Grazvydas Ignotas
2010-04-23 5:57 ` Johannes Berg
2010-04-23 6:01 ` Luis R. Rodriguez
2010-04-22 20:50 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271969459.11483.3.camel@mj \
--to=proski@gnu.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).