From: Pavel Roskin <proski@gnu.org>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: lrodriguez@atheros.com, linux-wireless@vger.kernel.org,
mcgrof@infradead.org
Subject: Re: [PATCH] compat: backport usb_alloc_coherent() and usb_free_coherent()
Date: Mon, 03 May 2010 15:10:38 -0400 [thread overview]
Message-ID: <1272913838.2607.5.camel@mj> (raw)
In-Reply-To: <1272911773-18486-1-git-send-email-hauke@hauke-m.de>
On Mon, 2010-05-03 at 20:36 +0200, Hauke Mehrtens wrote:
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> include/linux/compat-2.6.35.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/compat-2.6.35.h b/include/linux/compat-2.6.35.h
> index 9132ecb..62c54cf 100644
> --- a/include/linux/compat-2.6.35.h
> +++ b/include/linux/compat-2.6.35.h
> @@ -19,6 +19,8 @@ static inline wait_queue_head_t *sk_sleep(struct sock *sk)
> {
> return sk->sk_sleep;
> }
> +#define usb_alloc_coherent usb_buffer_alloc
> +#define usb_free_coherent usb_buffer_free
I believe macros with arguments are preferred.
It really matters in case of simple names that can be reasonably used as
variable names as well (e.g. "max").
In this case, it's more a matter of style and readability.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-05-03 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 18:36 [PATCH] compat: backport usb_alloc_coherent() and usb_free_coherent() Hauke Mehrtens
2010-05-03 19:10 ` Pavel Roskin [this message]
2010-05-03 19:36 ` [PATCH v2] " Hauke Mehrtens
2010-05-03 23:58 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272913838.2607.5.camel@mj \
--to=proski@gnu.org \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mcgrof@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).