From: Pavel Roskin <proski@gnu.org>
To: Stefan Lippers-Hollmann <s.L-H@gmx.de>
Cc: Gertjan van Wingerde <gwingerde@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
Ivo van Doorn <IvDoorn@gmail.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 2/4] rt2x00: Enable RT30xx by default.
Date: Mon, 03 May 2010 18:44:03 -0400 [thread overview]
Message-ID: <1272926643.6239.1.camel@mj> (raw)
In-Reply-To: <201005040008.36956.s.L-H@gmx.de>
On Tue, 2010-05-04 at 00:08 +0200, Stefan Lippers-Hollmann wrote:
> RT2800PCI_RT30XX is not a new/ separate module, its only function is to
> limit the PCI ID space (to not claim PCI IDs for chipset generations not
> yet debugged properly) of rt2800pci.ko; this symbol isn't even used
> anywhere else than within the PCI table.
I realize that. Still, somebody upstream can object.
> A 100% equivalent patch would be
> to just drop the config option completely. I doubt that doing that would
> meet resistance, as it merely adds previously 'unknown' (to be supported)
> PCI IDs.
That's what I would do.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-05-03 22:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 20:43 [PATCH 0/4] rt2x00: Assorted fixes and cleanups Gertjan van Wingerde
2010-05-03 20:43 ` [PATCH 1/4] rt2x00: Remove rt2x00pci.h include from rt2800lib Gertjan van Wingerde
2010-05-03 20:43 ` [PATCH 2/4] rt2x00: Enable RT30xx by default Gertjan van Wingerde
2010-05-03 20:59 ` Pavel Roskin
2010-05-03 22:08 ` Stefan Lippers-Hollmann
2010-05-03 22:44 ` Pavel Roskin [this message]
2010-05-04 3:31 ` Gertjan van Wingerde
2010-05-04 17:17 ` John W. Linville
2010-05-04 18:22 ` Gertjan van Wingerde
2010-05-04 19:09 ` Walter Goldens
2010-05-04 19:13 ` Gertjan van Wingerde
2010-05-03 20:43 ` [PATCH 3/4] rt2x00: Fix HT40+/HT40- setting in rt2800 Gertjan van Wingerde
2010-05-06 6:26 ` [rt2x00-users] " Benoit Papillault
2010-05-03 20:43 ` [PATCH 4/4] rt2x00: Register frame length in TX entry descriptor instead of L2PAD Gertjan van Wingerde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272926643.6239.1.camel@mj \
--to=proski@gnu.org \
--cc=IvDoorn@gmail.com \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=s.L-H@gmx.de \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).