linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Bruno Randolf <br1@einfach.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	holgerschurig@gmail.com
Subject: Re: [RFC PATCH 1/2] mac80211: Add nl80211 antenna configuration
Date: Tue, 11 May 2010 10:50:23 +0200	[thread overview]
Message-ID: <1273567823.3669.23.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100511083900.28289.43864.stgit@tt-desk>

On Tue, 2010-05-11 at 17:39 +0900, Bruno Randolf wrote:

> +	[NL80211_ATTR_ANTENNA_TX] = { .type = NLA_U8 },
> +	[NL80211_ATTR_ANTENNA_RX] = { .type = NLA_U8 },
>  };

> +	tx_ant = nla_get_u8(info->attrs[NL80211_ATTR_ANTENNA_TX]);
> +	rx_ant = nla_get_u8(info->attrs[NL80211_ATTR_ANTENNA_RX]);

> +	NLA_PUT_U32(msg, NL80211_ATTR_ANTENNA_TX, tx_ant);
> +	NLA_PUT_U32(msg, NL80211_ATTR_ANTENNA_RX, rx_ant);

That isn't right.

johannes


  reply	other threads:[~2010-05-11  8:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11  8:38 [RFC PATCH 0/2] mac80211: antenna configuration Bruno Randolf
2010-05-11  8:39 ` [RFC PATCH 1/2] mac80211: Add nl80211 " Bruno Randolf
2010-05-11  8:50   ` Johannes Berg [this message]
2010-05-11  8:51   ` Johannes Berg
2010-05-11  8:52   ` Johannes Berg
2010-05-11 18:14   ` Luis R. Rodriguez
2010-05-11 18:19     ` Johannes Berg
2010-05-11 18:26       ` Luis R. Rodriguez
2010-05-12  1:39     ` Bruno Randolf
2010-05-12  1:51       ` Luis R. Rodriguez
2010-05-11  8:39 ` [RFC PATCH 2/2] ath5k: Add support for cfg80211 antenna setting Bruno Randolf
2010-05-11  8:50   ` Johannes Berg
2010-05-11  8:53 ` [RFC PATCH 0/2] mac80211: antenna configuration Johannes Berg
2010-05-11  9:34   ` Bruno Randolf
2010-05-11 18:17     ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273567823.3669.23.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=br1@einfach.org \
    --cc=holgerschurig@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).