Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Sujith.Manoharan@atheros.com
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/5] ath9k_htc: Lock sta_notify() callback
Date: Tue, 11 May 2010 12:57:33 +0200	[thread overview]
Message-ID: <1273575453.3669.55.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <19433.14190.31764.174876@gargle.gargle.HOWL>

On Tue, 2010-05-11 at 16:24 +0530, Sujith.Manoharan@atheros.com wrote:
> Since ->sta_notify() can sleep, protect
> the callback with a mutex.

While this may be a correct change, it's not a correct description :)

You should be locking _data_, not _code_, and due to mac80211 the
callback cannot be invoked twice at the same time anyway.

johannes



  reply	other threads:[~2010-05-11 10:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11 10:54 [PATCH 1/5] ath9k_htc: Lock sta_notify() callback Sujith.Manoharan
2010-05-11 10:57 ` Johannes Berg [this message]
2010-05-11 11:17   ` Sujith.Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273575453.3669.55.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Sujith.Manoharan@atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox