Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Roberto Riggio <roberto.riggio@create-net.org>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
	linux-wireless@vger.kernel.org
Subject: Re: Packet injection with ath9k
Date: Wed, 12 May 2010 18:46:46 +0200	[thread overview]
Message-ID: <1273682806.3979.7.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4BEADA79.5050000@create-net.org>

On Wed, 2010-05-12 at 18:42 +0200, Roberto Riggio wrote:
> On 05/09/2010 10:24 PM, Gábor Stefanik wrote:
> >>     u_int16_t       it_len;
> >>     u_int32_t       it_present;
> >>      
> > AFAIK these 2 fields need to be little-endian even on big-endian
> > machines. If your system is big-endian, this can cause problems.
> >    
> 
> Thanks, that was indeed the issue. I totally missed this info
> in the radiotap website. Everything is working fine now.

I'd make it more prominent, but ... this is what it says now:

Important Radiotap Characteristics

      * Fields are strictly ordered; The developer can specify any
        combination of fields, but the data must appear following the
        radiotap header in the order they are specified in the
        it_present bitmask (or more accurately, in the order the bit
        numbers for the it_present bitmask are defined).
      * Data is specified in little endian byte-order, all data fields
        including the it_version, it_len and it_present fields in the
        radiotap header are to be specified in little endian byte-order.
        This wiki has adopted the Linux convention of using __le64,
        __le32 and __le16 for 64-, 32- and 16-bit little endian
        quantities.

johannes


      reply	other threads:[~2010-05-12 16:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-07 16:13 Packet injection with ath9k Roberto Riggio
2010-05-07 16:35 ` Gábor Stefanik
2010-05-07 19:09   ` Roberto Riggio
2010-05-09 20:24     ` Gábor Stefanik
2010-05-12 16:42       ` Roberto Riggio
2010-05-12 16:46         ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273682806.3979.7.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netrolller.3d@gmail.com \
    --cc=roberto.riggio@create-net.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox