From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
To: ext Johannes Berg <johannes@sipsolutions.net>
Cc: "Coelho Luciano (Nokia-D/Helsinki)" <Luciano.Coelho@nokia.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/6] wl1271: Flush TX buffers to air before going to idle
Date: Mon, 24 May 2010 11:51:27 +0300 [thread overview]
Message-ID: <1274691087.5277.54.camel@wimaxnb.nmp.nokia.com> (raw)
In-Reply-To: <1274689723.3743.16.camel@jlt3.sipsolutions.net>
On Mon, 2010-05-24 at 10:28 +0200, ext Johannes Berg wrote:
> On Mon, 2010-05-24 at 11:18 +0300, Luciano Coelho wrote:
> > From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> >
> > The mac80211 changes to idle almost immediately after transmitting some
> > frames, such as deauth etc. When going to idle, the wl1271 is disconnected,
> > which causes TX frames already on buffers, but not yet transmitted, to be
> > deleted.
> >
> > To make sure deauth frames reach the air, allow the TX buffers to flush
> > before proceeding to idle.
>
> Actually, mac80211 executes a flush() request before idle, so you could
> just implement the flush callback and also benefit in some other
> scenarios (though the software scan one you don't care about)
Yeah. I noticed that later while working with other stuff.
I already have planned to move the flush to flush() ;)
-Juuso
> johannes
>
next prev parent reply other threads:[~2010-05-24 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 8:18 [PATCH 0/6] wl1271: patches for wk20 Luciano Coelho
2010-05-24 8:18 ` [PATCH 1/6] wl1271: Prevent dropping of TX frames in joins Luciano Coelho
2010-05-24 8:18 ` [PATCH 2/6] wl1271: Idle handling into own function Luciano Coelho
2010-05-24 8:18 ` [PATCH 3/6] wl1271: Flush TX buffers to air before going to idle Luciano Coelho
2010-05-24 8:28 ` Johannes Berg
2010-05-24 8:51 ` Juuso Oikarinen [this message]
2010-05-24 8:18 ` [PATCH 4/6] wl1271: the core wl1271 module shouldn't depend on SPI_MASTER Luciano Coelho
2010-05-24 8:18 ` [PATCH 5/6] wl1271: Use proper rates for PSM entry/exit null-funcs for 5GHz Luciano Coelho
2010-05-24 8:18 ` [PATCH 6/6] wl1271: Fix scan parameter handling " Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274691087.5277.54.camel@wimaxnb.nmp.nokia.com \
--to=juuso.oikarinen@nokia.com \
--cc=Luciano.Coelho@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox