From: Johannes Berg <johannes@sipsolutions.net>
To: Joker Joker <jokesareonyou@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: Path for fixed channel issue in aircrack-ng suite
Date: Tue, 25 May 2010 10:11:11 +0200 [thread overview]
Message-ID: <1274775071.3635.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AANLkTinAnMwY0ZCetUmUbuhsp3rB360xvlaGM5ifdFHz@mail.gmail.com>
On Tue, 2010-05-25 at 01:07 -0400, Joker Joker wrote:
> Below is a patch to fix monitor mode channel issue for aircrack-ng suit
> (fixed channel mon0: -1)
>
> diff --git a/net/wireless/chan.c b/net/wireless/chan.c
> index d92d088..93f6c19 100644
> --- a/net/wireless/chan.c
> +++ b/net/wireless/chan.c
> @@ -48,6 +48,7 @@ int cfg80211_set_freq(struct cfg80211_registered_device *rdev,
> enum nl80211_channel_type channel_type)
> {
> struct ieee80211_channel *chan;
> + struct wireless_dev *old_wdev = wdev;
> int result;
>
> if (wdev->iftype == NL80211_IFTYPE_MONITOR)
> @@ -73,8 +74,8 @@ int cfg80211_set_freq(struct cfg80211_registered_device *rdev,
> if (result)
> return result;
>
> - if (wdev)
> - wdev->channel = chan;
> + wdev = old_wdev;
> + wdev->channel = chan;
NACK. That will crash when there really is no interface being passed in.
johannes
next prev parent reply other threads:[~2010-05-25 8:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 5:07 Path for fixed channel issue in aircrack-ng suite Joker Joker
2010-05-25 8:11 ` Johannes Berg [this message]
2010-05-25 22:54 ` Gábor Stefanik
2010-05-26 7:51 ` Johannes Berg
2010-05-27 3:51 ` Richard Farina
2010-05-28 18:28 ` Richard Farina
2010-06-01 18:28 ` Path for fixed channel issue in aircrack-ng suite [V2] Maxim Levitsky
2010-06-01 18:36 ` Richard Farina
2010-06-01 19:19 ` Johannes Berg
2010-06-01 19:50 ` Richard Farina
2010-06-01 20:19 ` Johannes Berg
2010-06-01 21:53 ` Thomas d'Otreppe
2010-06-01 19:53 ` Maxim Levitsky
2010-06-01 20:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274775071.3635.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jokesareonyou@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).