linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211: Fix basic rates for created IBSS networks
@ 2010-05-26 12:34 Juuso Oikarinen
  2010-05-26 12:34 ` Johannes Berg
  0 siblings, 1 reply; 3+ messages in thread
From: Juuso Oikarinen @ 2010-05-26 12:34 UTC (permalink / raw)
  To: linville; +Cc: linux-wireless

Currently the mac80211 marks rates 1 and 2 mbps as basic rates for created
ad-hoc networks. To be certifiable, rates 1, 2, 5.5 and 12 need to be marked
basic.

Change this.

Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
---
 net/mac80211/ibss.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index b2cc1fd..448cf57 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -529,7 +529,8 @@ static void ieee80211_sta_create_ibss(struct ieee80211_sub_if_data *sdata)
 		sdata->drop_unencrypted = 0;
 
 	__ieee80211_sta_join_ibss(sdata, bssid, sdata->vif.bss_conf.beacon_int,
-				  ifibss->channel, 3, /* first two are basic */
+				  ifibss->channel,
+				  15, /* 1, 2, 5.5 and 12 are basic */
 				  capability, 0);
 }
 
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mac80211: Fix basic rates for created IBSS networks
  2010-05-26 12:34 [PATCH] mac80211: Fix basic rates for created IBSS networks Juuso Oikarinen
@ 2010-05-26 12:34 ` Johannes Berg
  2010-05-26 12:42   ` Juuso Oikarinen
  0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2010-05-26 12:34 UTC (permalink / raw)
  To: Juuso Oikarinen; +Cc: linville, linux-wireless

On Wed, 2010-05-26 at 15:34 +0300, Juuso Oikarinen wrote:
> Currently the mac80211 marks rates 1 and 2 mbps as basic rates for created
> ad-hoc networks. To be certifiable, rates 1, 2, 5.5 and 12 need to be marked
> basic.
> 
> Change this.
> 
> Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> ---
>  net/mac80211/ibss.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
> index b2cc1fd..448cf57 100644
> --- a/net/mac80211/ibss.c
> +++ b/net/mac80211/ibss.c
> @@ -529,7 +529,8 @@ static void ieee80211_sta_create_ibss(struct ieee80211_sub_if_data *sdata)
>  		sdata->drop_unencrypted = 0;
>  
>  	__ieee80211_sta_join_ibss(sdata, bssid, sdata->vif.bss_conf.beacon_int,
> -				  ifibss->channel, 3, /* first two are basic */
> +				  ifibss->channel,
> +				  15, /* 1, 2, 5.5 and 12 are basic */

12?

In any case, this is incorrect in 5 GHz (at least the comment is).

johannes


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mac80211: Fix basic rates for created IBSS networks
  2010-05-26 12:34 ` Johannes Berg
@ 2010-05-26 12:42   ` Juuso Oikarinen
  0 siblings, 0 replies; 3+ messages in thread
From: Juuso Oikarinen @ 2010-05-26 12:42 UTC (permalink / raw)
  To: ext Johannes Berg; +Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org

On Wed, 2010-05-26 at 14:34 +0200, ext Johannes Berg wrote:
> On Wed, 2010-05-26 at 15:34 +0300, Juuso Oikarinen wrote:
> > Currently the mac80211 marks rates 1 and 2 mbps as basic rates for created
> > ad-hoc networks. To be certifiable, rates 1, 2, 5.5 and 12 need to be marked
> > basic.
> > 
> > Change this.
> > 
> > Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> > ---
> >  net/mac80211/ibss.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
> > index b2cc1fd..448cf57 100644
> > --- a/net/mac80211/ibss.c
> > +++ b/net/mac80211/ibss.c
> > @@ -529,7 +529,8 @@ static void ieee80211_sta_create_ibss(struct ieee80211_sub_if_data *sdata)
> >  		sdata->drop_unencrypted = 0;
> >  
> >  	__ieee80211_sta_join_ibss(sdata, bssid, sdata->vif.bss_conf.beacon_int,
> > -				  ifibss->channel, 3, /* first two are basic */
> > +				  ifibss->channel,
> > +				  15, /* 1, 2, 5.5 and 12 are basic */
> 
> 12?
> 
> In any case, this is incorrect in 5 GHz (at least the comment is).

Damn! The comment has a typo!

I must have a serious brain leak.

-Juuso

> johannes
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-05-26 12:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-26 12:34 [PATCH] mac80211: Fix basic rates for created IBSS networks Juuso Oikarinen
2010-05-26 12:34 ` Johannes Berg
2010-05-26 12:42   ` Juuso Oikarinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).