Re: [RFC PATCHv2] mac80211: Add support for hardware ARP query filtering

[Juuso Oikarinen <juuso.oikarinen@nokia.com>]

On Wed, 2010-05-26 at 13:52 +0200, ext Johannes Berg wrote:
> On Wed, 2010-05-26 at 14:29 +0300, Juuso Oikarinen wrote:
> 
> > --- a/net/mac80211/mlme.c
> > +++ b/net/mac80211/mlme.c
> > @@ -858,6 +858,10 @@ static void ieee80211_set_associated(struct ieee80211_sub_if_data *sdata,
> >  	ieee80211_recalc_smps(local, sdata);
> >  	mutex_unlock(&local->iflist_mtx);
> >  
> > +	rtnl_lock();
> > +	ieee80211_set_arp_filter(sdata);
> > +	rtnl_unlock();
> > +
> 
> Please analyse locking in more detail and enable lockdep :)
> 
> This will cause deadlocks.

I have lockdep permanently enabled in my development kernel. It has
given me no complaints in testing with the corresponding wl1271 driver
patch.

But I will look into those locks further if I can figure out any
deadlock scenarios.

-Juuso


> johannes
>