From: Johannes Berg <johannes@sipsolutions.net>
To: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC PATCHv2] mac80211: Add support for hardware ARP query filtering
Date: Wed, 26 May 2010 14:52:01 +0200 [thread overview]
Message-ID: <1274878321.3658.7.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1274878272.5277.1890.camel@wimaxnb.nmp.nokia.com>
On Wed, 2010-05-26 at 15:51 +0300, Juuso Oikarinen wrote:
> > > + rtnl_lock();
> > > + ieee80211_set_arp_filter(sdata);
> > > + rtnl_unlock();
> > > +
> >
> > Please analyse locking in more detail and enable lockdep :)
> >
> > This will cause deadlocks.
>
> I have lockdep permanently enabled in my development kernel. It has
> given me no complaints in testing with the corresponding wl1271 driver
> patch.
>
> But I will look into those locks further if I can figure out any
> deadlock scenarios.
Interesting .. because for sure a lot of the ieee80211_mgd_* functions
are called with rtnl held and lock the mgd mutex, but it is the other
way around here.
johannes
next prev parent reply other threads:[~2010-05-26 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 11:29 [RFC PATCHv2] mac80211: Add support for hardware ARP query filtering Juuso Oikarinen
2010-05-26 11:52 ` Johannes Berg
2010-05-26 12:51 ` Juuso Oikarinen
2010-05-26 12:52 ` Johannes Berg [this message]
2010-05-27 5:36 ` Juuso Oikarinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274878321.3658.7.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).