Re: [PATCHv2] mac80211: Fix basic rates for created IBSS networks

[Juuso Oikarinen <juuso.oikarinen@nokia.com>]

On Wed, 2010-05-26 at 14:53 +0200, ext Johannes Berg wrote:
> On Wed, 2010-05-26 at 15:48 +0300, Juuso Oikarinen wrote:
> > Currently the mac80211 marks rates 1 and 2 mbps as basic rates for created
> > ad-hoc networks. To be certifiable, rates 1, 2, 5.5 and 11 need to be marked
> > basic.
> > 
> > Change this.
> > 
> > Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> > ---
> >  net/mac80211/ibss.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
> > index b2cc1fd..0b8360c 100644
> > --- a/net/mac80211/ibss.c
> > +++ b/net/mac80211/ibss.c
> > @@ -529,7 +529,8 @@ static void ieee80211_sta_create_ibss(struct ieee80211_sub_if_data *sdata)
> >  		sdata->drop_unencrypted = 0;
> >  
> >  	__ieee80211_sta_join_ibss(sdata, bssid, sdata->vif.bss_conf.beacon_int,
> > -				  ifibss->channel, 3, /* first two are basic */
> > +				  ifibss->channel,
> > +				  15, /* 1, 2, 5.5 and 11 are basic */
> 
> It's still wrong for 5 GHz.

Yes, it is as wrong for 5GHz as it was before the change.

> 
> We've had this discussion before. Making more rates required will break
> compatibility with 11b devices.

I don't understand this. AFAIK also in 11b all these rates are
mandatory. How come this breaks 11b?

This change is for creating IBSS, not joining. In case of joining, we
still adhere to the basic rates set by the creator, or that is what I
understand based on the code.

> What should be done here is add a basic rates parameter to the IBSS join
> nl80211 command so that you can decide at runtime which rates to use as
> basic.

Yeah, this is a solution needed latest when 5GHz support is implemented.

-Juuso

> johannes
>