From: Johannes Berg <johannes@sipsolutions.net>
To: Bruno Randolf <br1@einfach.org>
Cc: Juuso Oikarinen <juuso.oikarinen@nokia.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCHv2] mac80211: Fix basic rates for created IBSS networks
Date: Thu, 27 May 2010 10:12:01 +0200 [thread overview]
Message-ID: <1274947921.3669.17.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201005270941.30654.br1@einfach.org>
On Thu, 2010-05-27 at 09:41 +0900, Bruno Randolf wrote:
> > + } else {
> > + /*
> > + * If no rates were explicitly configured,
> > + * use the mandatory rate set for 11b or
> > + * 11a for maximum compatibility.
> > + */
> > + struct ieee80211_supported_band *sband =
> > + wiphy->bands[ibss.channel->band];
> > + int j;
> > + u32 flag = ibss.channel->band == IEEE80211_BAND_5GHZ ?
> > + IEEE80211_RATE_MANDATORY_A :
> > + IEEE80211_RATE_MANDATORY_B;
> > +
> > + for (j = 0; j < sband->n_bitrates; j++) {
> > + if (sband->bitrates[j].flags & flag)
> > + ibss.basic_rates |= j;
> > + }
> > + }
>
> couldn't we use ieee80211_mandatory_rates() here?
Yeah, but it would have to migrate to cfg80211.
johannes
next prev parent reply other threads:[~2010-05-27 8:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 12:48 [PATCHv2] mac80211: Fix basic rates for created IBSS networks Juuso Oikarinen
2010-05-26 12:53 ` Johannes Berg
2010-05-26 13:13 ` Juuso Oikarinen
2010-05-26 13:27 ` Johannes Berg
2010-05-27 4:50 ` Juuso Oikarinen
2010-05-26 14:14 ` Johannes Berg
2010-05-27 0:41 ` Bruno Randolf
2010-05-27 8:12 ` Johannes Berg [this message]
2010-05-27 0:45 ` [PATCH] mac80211: mark 1, 2, 5.5 and 11Mbps as mandatory rates for 802.11b Bruno Randolf
2010-05-27 6:02 ` [ath5k-devel] " Benoit Papillault
2010-05-27 8:08 ` Johannes Berg
2010-05-27 8:11 ` Johannes Berg
2010-05-27 12:09 ` Benoit Papillault
2010-05-27 12:13 ` Johannes Berg
2010-05-27 5:06 ` [PATCHv2] mac80211: Fix basic rates for created IBSS networks Juuso Oikarinen
2010-05-27 8:11 ` Johannes Berg
2010-05-27 8:28 ` Juuso Oikarinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274947921.3669.17.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=br1@einfach.org \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).