From: Johannes Berg <johannes@sipsolutions.net>
To: Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: Removed warning from cfg80211_send_rx_auth
Date: Fri, 28 May 2010 10:02:47 +0200 [thread overview]
Message-ID: <1275033767.3909.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1275029755.20619.1261.camel@paavo-desktop>
On Fri, 2010-05-28 at 09:55 +0300, Teemu Paasikivi wrote:
> > Yes .. I understand the scenario. You don't want to filter it out, you
> > want to abort the authentication so you kill the work for it and never
> > send the timeout to cfg80211.
> Isn't that already done? Aborting the authentication, I mean.
Evidently not? ieee80211_rx_mgmt_deauth() doesn't touch the work.
> The
> warning is triggered by the authentication response in the
> cfg80211_send_rx_auth function.
Right, ieee80211_rx_mgmt_deauth() removed the auth work, that frame
would never make it up to cfg80211.
> Removal of the warning would keep logs
> clean. I suppose that in the case where wdev->sme_state !=
> CFG80211_SME_CONNECTING we could just bail out from the
> cfg80211_send_rx_auth function instead of removing the warning.
No ... don't modify cfg80211.
johannes
prev parent reply other threads:[~2010-05-28 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 10:43 [PATCH] cfg80211: Removed warning from cfg80211_send_rx_auth Teemu Paasikivi
2010-05-26 11:21 ` Johannes Berg
2010-05-27 8:48 ` Teemu Paasikivi
2010-05-27 9:27 ` Johannes Berg
2010-05-28 6:55 ` Teemu Paasikivi
2010-05-28 8:02 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275033767.3909.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ext-teemu.3.paasikivi@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).