From: Johannes Berg <johannes@sipsolutions.net>
To: Ivo Van Doorn <ivdoorn@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: rt73usb & Mesh network
Date: Fri, 04 Jun 2010 10:13:46 +0200 [thread overview]
Message-ID: <1275639226.9953.6.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AANLkTinChab0MINV64h1UFb7YUxVRNvDztRbcKxZuDJO@mail.gmail.com>
On Thu, 2010-06-03 at 12:49 +0200, Ivo Van Doorn wrote:
> The stacktrace indicates the problem is a scheduling while atomic bug,
> however this seems to be triggerd by mac80211 making the bss_info_changed()
> callback function in atomic context. But the current documentation of mac80211
> implies that this callback function is allowed to sleep.
>
> Could you check the stacktrace to see if this is indeed a mac80211 bug rather
> then rt73usb?
It clearly is, at least a documentation issue in that it must not sleep
in mesh mode ... fixing it would seem to require major locking changes
in the mesh implementation, and unfortunately we don't have anybody who
has enough time to care about it.
FWIW, if anybody is interested to fix this, it seems like it should be
safe to use sta_mtx instead of rcu_read_lock() for station protection
and change a lot of mesh stuff to not use the per-sta spinlock. Must be
very careful with this though since some stuff is in the RX path.
Short of doing that, I can only suggest disabling mesh for drivers that
require being able to sleep.
johannes
prev parent reply other threads:[~2010-06-04 8:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 10:49 rt73usb & Mesh network Ivo Van Doorn
2010-06-04 8:13 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275639226.9953.6.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).