From: reinette chatre <reinette.chatre@intel.com>
To: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: Add netif state checking to ieee80211_ifa_changed
Date: Mon, 07 Jun 2010 09:52:23 -0700 [thread overview]
Message-ID: <1275929543.1835.8674.camel@rchatre-DESK> (raw)
In-Reply-To: <1275897132-10932-1-git-send-email-juuso.oikarinen@nokia.com>
Hi Juuso,
On Mon, 2010-06-07 at 00:52 -0700, Juuso Oikarinen wrote:
> There's a window for ieee80211_ifa_changed() to get called whilst the
> managed mode mutex has not been initialized when opening and stopping the
> interface. Currently this causes a kernel BUG like the following:
>
> [ 132.460013] kernel BUG at /home/wifi/iwlwifi-2.6/net/mac80211/main.c:380!
> [ 132.460013] invalid opcode: 0000 [#1] SMP
>
> The mutex is initialized during open(), hence once netif_running() is true,
> the mutex should be valid. Fix by adding a netif_running() check to the
> function.
>
> Reported-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Thank you very much. I've been running with this patch for more than ten
iterations of my testing and I have not encountered this issue again.
Tested-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
prev parent reply other threads:[~2010-06-07 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 7:52 [PATCH] mac80211: Add netif state checking to ieee80211_ifa_changed Juuso Oikarinen
2010-06-07 16:52 ` reinette chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275929543.1835.8674.camel@rchatre-DESK \
--to=reinette.chatre@intel.com \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox