From: Johannes Berg <johannes@sipsolutions.net>
To: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"reinette.chatre@intel.com" <reinette.chatre@intel.com>
Subject: Re: [PATCHv3] mac80211: Fix circular locking dependency in ARP filter handling
Date: Wed, 09 Jun 2010 10:54:30 +0200 [thread overview]
Message-ID: <1276073670.3727.12.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1276073421.5277.33026.camel@wimaxnb.nmp.nokia.com>
On Wed, 2010-06-09 at 11:50 +0300, Juuso Oikarinen wrote:
> On Wed, 2010-06-09 at 09:32 +0200, ext Johannes Berg wrote:
> > On Wed, 2010-06-09 at 09:50 +0300, Juuso Oikarinen wrote:
> >
> > > v3: - queue reconfig filter work to kernel default wq instead of mac80211 wq
> >
> > I think it would make more sense to use a different lock instead, like
> > the iflist mutex?
>
> Yeah had that originally, but apparently the iflist mutex is acquired
> *after* the mgd mutex in some places of the code, especially all around
> mlme.c, and here I would have to acquire them in reverse order. So I
> changed to the rtnl lock.
Ah, right.
However I'm a bit worried that making this workqueue change will allow
the filter reconfigure to cross with suspend, which might mean it could
execute after the device is suspended?
johannes
next prev parent reply other threads:[~2010-06-09 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 6:50 [PATCHv3] mac80211: Fix circular locking dependency in ARP filter handling Juuso Oikarinen
2010-06-09 7:32 ` Johannes Berg
2010-06-09 8:50 ` Juuso Oikarinen
2010-06-09 8:54 ` Johannes Berg [this message]
2010-06-09 9:08 ` Juuso Oikarinen
2010-06-09 9:36 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276073670.3727.12.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).