From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from c60.cesmail.net ([216.154.195.49]:50510 "EHLO c60.cesmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979Ab0FLRrA (ORCPT ); Sat, 12 Jun 2010 13:47:00 -0400 Subject: Re: [PATCH 4/7] ath9k_hw: remove ATH9K_CAP_TKIP_SPLIT From: Pavel Roskin To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, lrodriguez@atheros.com, linville@tuxdriver.com In-Reply-To: <4C13C5B5.3080609@openwrt.org> References: <1276356154-66545-1-git-send-email-nbd@openwrt.org> <1276356154-66545-2-git-send-email-nbd@openwrt.org> <1276356154-66545-3-git-send-email-nbd@openwrt.org> <1276356154-66545-4-git-send-email-nbd@openwrt.org> <1276363723.2625.7.camel@ct> <4C13C5B5.3080609@openwrt.org> Content-Type: text/plain Date: Sat, 12 Jun 2010 13:46:43 -0400 Message-Id: <1276364803.2625.22.camel@ct> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 2010-06-12 at 19:36 +0200, Felix Fietkau wrote: > On 2010-06-12 7:28 PM, Pavel Roskin wrote: > > On Sat, 2010-06-12 at 17:22 +0200, Felix Fietkau wrote: > >> This is only used as a workaround for an issue in one specific hw revision. > > > > Is that workaround needed for both PCI and USB? If not, > > common->splitmic should not be needed and further cleanup should be > > possible. > It's only needed for PCI. Oh, I see that common->splitmic is used in common.c where misc_mode is not available. Then further simplification would not be as trivial as I though. Sorry for the noise. -- Regards, Pavel Roskin