Re: [PATCH] iw: Configure basic rates when joining ibss network

[Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>]

On Tue, 2010-06-15 at 09:18 +0200, ext Johannes Berg wrote:
> On Tue, 2010-06-15 at 09:24 +0300, Teemu Paasikivi wrote:
> 
> > @@ -41,6 +46,31 @@ static int join_ibss(struct nl80211_state *state,
> >  		argc--;
> >  	}
> >  
> > +	/* basic rates */
> > +	if (argc > 1 && strcmp(argv[0], "basic-rates") == 0) {
> > +		argv++;
> > +		argc--;
> > +
> > +		value = strtok_r(argv[0], ",", &sptr);
> > +
> > +		while (value && n_rates < NL80211_MAX_SUPP_RATES) {
> > +			rate = atof(value);
> 
> should that use strtod() to check you didn't give "1a,2b,6c,11d"?
> 
Sure, it can be used. I think I'll change it to use that. I was just
wondering that how much the values given by the user should/could be
checked here.

> johannes
> 

Br,

Teemu