From: Pavel Roskin <proski@gnu.org>
To: Vivek Natarajan <vnatarajan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Fix the LED behaviour in idle unassociated state.
Date: Wed, 23 Jun 2010 13:55:40 -0400 [thread overview]
Message-ID: <1277315740.3562.6.camel@mj> (raw)
In-Reply-To: <1277275109-4662-1-git-send-email-vnatarajan@atheros.com>
On Wed, 2010-06-23 at 12:08 +0530, Vivek Natarajan wrote:
> LED should be ON when the radio is put into FULL SLEEP mode during the idle
> unassociated state.
Why? Is there any written policy for the LED behavior? I think we want
to conserve power if sleeping, which means turning LEDs off.
Or is it a workaround for some quirk in Atheros hardware?
In any case, I don't like the new comment. The comment says "Keep the
LED on...", but the code is still turning the LED off.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-06-23 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 6:38 [PATCH] ath9k: Fix the LED behaviour in idle unassociated state Vivek Natarajan
2010-06-23 17:55 ` Pavel Roskin [this message]
2010-06-24 4:56 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277315740.3562.6.camel@mj \
--to=proski@gnu.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vnatarajan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox