From: Dan Williams <dcbw@redhat.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, dkiran@marvell.com,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH 2/3] libertas: unmangle capability value
Date: Wed, 23 Jun 2010 16:24:49 -0700 [thread overview]
Message-ID: <1277335489.25126.30.camel@dcbw.foobar.com> (raw)
In-Reply-To: <1277303846-17257-2-git-send-email-linville@tuxdriver.com>
On Wed, 2010-06-23 at 10:37 -0400, John W. Linville wrote:
> Address fall-out from patch converting libertas to use cfg80211...
>
> +drivers/net/wireless/libertas/cfg.c:1844:13: warning: incorrect type in assignment (different base types)
> +drivers/net/wireless/libertas/cfg.c:1844:13: expected unsigned short [unsigned] [usertype] capability
> +drivers/net/wireless/libertas/cfg.c:1844:13: got restricted __le16 [usertype] <noident>
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> drivers/net/wireless/libertas/cfg.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/libertas/cfg.c b/drivers/net/wireless/libertas/cfg.c
> index 23c1dc6..f36cc97 100644
> --- a/drivers/net/wireless/libertas/cfg.c
> +++ b/drivers/net/wireless/libertas/cfg.c
> @@ -1841,7 +1841,7 @@ static int lbs_ibss_start_new(struct lbs_private *priv,
> if (MRVL_FW_MAJOR_REV(priv->fwrelease) <= 8)
> cmd.probedelay = cpu_to_le16(CMD_SCAN_PROBE_DELAY_TIME);
> /* TODO: mix in WLAN_CAPABILITY_PRIVACY */
> - capability = cpu_to_le16(WLAN_CAPABILITY_IBSS);
> + capability = WLAN_CAPABILITY_IBSS;
> cmd.capability = cpu_to_le16(capability);
> lbs_add_rates(cmd.rates);
>
next prev parent reply other threads:[~2010-06-23 23:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 16:31 [PATCH 1/3] Libertas: cfg80211 support Kiran Divekar
2010-06-14 12:40 ` Johannes Berg
2010-06-15 13:48 ` Holger Schurig
2010-06-23 8:25 ` Johannes Berg
2010-06-23 14:37 ` [PATCH 1/3] libertas: fix build error due to undefined symbol John W. Linville
2010-06-23 23:24 ` Dan Williams
2010-06-23 14:37 ` [PATCH 2/3] libertas: unmangle capability value John W. Linville
2010-06-23 23:24 ` Dan Williams [this message]
2010-06-23 14:37 ` [PATCH 3/3] libertas: mark lbs_ret_802_11d_domain_info static John W. Linville
2010-06-23 23:24 ` Dan Williams
2010-06-24 5:38 ` [PATCH 1/3] Libertas: cfg80211 support Kiran Divekar
2010-06-24 6:03 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277335489.25126.30.camel@dcbw.foobar.com \
--to=dcbw@redhat.com \
--cc=dkiran@marvell.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).