From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63001 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753855Ab0FWXY2 (ORCPT ); Wed, 23 Jun 2010 19:24:28 -0400 Subject: Re: [PATCH 1/3] libertas: fix build error due to undefined symbol From: Dan Williams To: "John W. Linville" Cc: linux-wireless@vger.kernel.org, dkiran@marvell.com, Johannes Berg In-Reply-To: <1277303846-17257-1-git-send-email-linville@tuxdriver.com> References: <1277281556.3642.6.camel@jlt3.sipsolutions.net> <1277303846-17257-1-git-send-email-linville@tuxdriver.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 23 Jun 2010 16:24:57 -0700 Message-ID: <1277335497.25126.31.camel@dcbw.foobar.com> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2010-06-23 at 10:37 -0400, John W. Linville wrote: > ERROR: "mesh_handler_def" [drivers/net/wireless/libertas/libertas.ko] undefined! > > Caused by a hunk missed by "Libertas: cfg80211 support" when building > with CONFIG_WIRELESS_EXT enabled. > > Signed-off-by: John W. Linville Acked-by: Dan Williams > --- > drivers/net/wireless/libertas/mesh.c | 3 --- > drivers/net/wireless/libertas/mesh.h | 5 ----- > 2 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/wireless/libertas/mesh.c b/drivers/net/wireless/libertas/mesh.c > index 00b36b0..bc5bc13 100644 > --- a/drivers/net/wireless/libertas/mesh.c > +++ b/drivers/net/wireless/libertas/mesh.c > @@ -370,9 +370,6 @@ int lbs_add_mesh(struct lbs_private *priv) > > SET_NETDEV_DEV(priv->mesh_dev, priv->dev->dev.parent); > > -#ifdef WIRELESS_EXT > - mesh_dev->wireless_handlers = &mesh_handler_def; > -#endif > mesh_dev->flags |= IFF_BROADCAST | IFF_MULTICAST; > /* Register virtual mesh interface */ > ret = register_netdev(mesh_dev); > diff --git a/drivers/net/wireless/libertas/mesh.h b/drivers/net/wireless/libertas/mesh.h > index e257330..84ea248 100644 > --- a/drivers/net/wireless/libertas/mesh.h > +++ b/drivers/net/wireless/libertas/mesh.h > @@ -70,11 +70,6 @@ void lbs_persist_config_init(struct net_device *net); > void lbs_persist_config_remove(struct net_device *net); > > > -/* WEXT handler */ > - > -extern struct iw_handler_def mesh_handler_def; > - > - > /* Ethtool statistics */ > > struct ethtool_stats;