From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>,
Gertjan van Wingerde <gwingerde@gmail.com>
Subject: Re: rt2x00 & mac80211: correct usage of ieee80211_beacon_get_tim?
Date: Sun, 27 Jun 2010 10:21:02 +0200 [thread overview]
Message-ID: <1277626862.3684.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201006251801.06209.helmut.schaa@googlemail.com>
On Fri, 2010-06-25 at 18:01 +0200, Helmut Schaa wrote:
> Am Donnerstag 24 Juni 2010 schrieb Johannes Berg:
> > b) You need to get a new beacon frame from mac80211 only when it
> > changes. You can do this from set_tim(). HOWEVER: since you're not
> > getting a new one from mac80211 all the time anyway, you NEED to
> > have the driver or firmware overwrite the DTIM count, like b43's
> > firmware for example will do.
>
> And the broad- and multicast buffering also needs to be done in the driver
> (when the fw/hw cannot handle it) as mac80211 uses its own DTIM count for
> deciding when to "release" buffered frames to the driver.
Well, yes, but I don't get it. Are you trying to conjure a third way of
doing things? How would you like it to work?
I don't understand why you expect to have a correct DTIM count field
when you don't pull every beacon from mac80211. If you pull each beacon
it's all correct. If you don't, you need to take care of everything DTIM
related, there's simply no way to do it differently.
Does your device fill the DTIM count field or does it not? That's really
the only thing you need to know, no?
johannes
next prev parent reply other threads:[~2010-06-27 8:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 13:21 rt2x00 & mac80211: correct usage of ieee80211_beacon_get_tim? Helmut Schaa
2010-06-24 14:32 ` John W. Linville
2010-06-24 15:51 ` Johannes Berg
2010-06-24 15:53 ` Johannes Berg
2010-06-24 15:54 ` Johannes Berg
2010-06-24 16:20 ` Helmut Schaa
2010-06-25 16:01 ` Helmut Schaa
2010-06-26 15:32 ` John W. Linville
2010-06-27 8:21 ` Johannes Berg [this message]
2010-06-27 19:00 ` Helmut Schaa
2010-07-02 17:12 ` Johannes Berg
2010-07-02 17:59 ` Helmut Schaa
2010-07-02 18:06 ` Johannes Berg
2010-07-02 18:20 ` Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277626862.3684.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gwingerde@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).