Re: [PATCH] mac80211: set carrier on for monitor interfaces on ieee80211_open

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2010-07-19 at 20:44 +0200, David Gnedt wrote:
> If a station interface is reused as monitor interface it is possible that
> the carrier is still set to off. This breaks packet injection on that
> monitor interface.
> Force the carrier on in monitor interface initialisation like it is also done
> for other interface types (e.g. adhoc, mesh point, ap).
> 
> Signed-off-by: David Gnedt <david.gnedt@davizone.at>

This looks good,

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> ---
>  net/mac80211/iface.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
> index 910729f..d07d223 100644
> --- a/net/mac80211/iface.c
> +++ b/net/mac80211/iface.c
> @@ -249,6 +249,8 @@ static int ieee80211_open(struct net_device *dev)
>  			local->fif_other_bss++;
> 
>  		ieee80211_configure_filter(local);
> +
> +		netif_carrier_on(dev);
>  		break;
>  	default:
>  		res = drv_add_interface(local, &sdata->vif);