From: Dan Williams <dcbw@redhat.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
Holger Schurig <holgerschurig@gmail.com>,
Amitkumar Karwar <akarwar@marvell.com>,
libertas-dev@lists.infradead.org
Subject: Re: [PATCH] libertas: convert new uses of __attribute__ ((packed)) to __packed
Date: Wed, 21 Jul 2010 12:58:26 -0700 [thread overview]
Message-ID: <1279742306.7267.4.camel@dcbw.foobar.com> (raw)
In-Reply-To: <1279118223-10219-1-git-send-email-linville@tuxdriver.com>
On Wed, 2010-07-14 at 10:37 -0400, John W. Linville wrote:
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Looks fine to me.
> ---
> drivers/net/wireless/libertas/cfg.c | 6 +++---
> drivers/net/wireless/libertas/host.h | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/libertas/cfg.c b/drivers/net/wireless/libertas/cfg.c
> index f36cc97..7e07416 100644
> --- a/drivers/net/wireless/libertas/cfg.c
> +++ b/drivers/net/wireless/libertas/cfg.c
> @@ -891,7 +891,7 @@ struct cmd_key_material {
>
> __le16 action;
> struct MrvlIEtype_keyParamSet param;
> -} __attribute__ ((packed));
> +} __packed;
>
> static int lbs_set_key_material(struct lbs_private *priv,
> int key_type,
> @@ -1395,7 +1395,7 @@ struct cmd_monitor_mode {
>
> __le16 action;
> __le16 mode;
> -} __attribute__ ((packed));
> +} __packed;
>
> static int lbs_enable_monitor_mode(struct lbs_private *priv, int mode)
> {
> @@ -1450,7 +1450,7 @@ struct cmd_rssi {
> __le16 nf;
> __le16 avg_snr;
> __le16 avg_nf;
> -} __attribute__ ((packed));
> +} __packed;
>
> static int lbs_get_signal(struct lbs_private *priv, s8 *signal, s8 *noise)
> {
> diff --git a/drivers/net/wireless/libertas/host.h b/drivers/net/wireless/libertas/host.h
> index db8e209..43d020c 100644
> --- a/drivers/net/wireless/libertas/host.h
> +++ b/drivers/net/wireless/libertas/host.h
> @@ -398,12 +398,12 @@ struct mrvl_ie_domain_param_set {
>
> u8 countrycode[COUNTRY_CODE_LEN];
> struct ieee80211_country_ie_triplet triplet[1];
> -} __attribute__ ((packed));
> +} __packed;
>
> struct cmd_ds_802_11d_domain_info {
> __le16 action;
> struct mrvl_ie_domain_param_set domain;
> -} __attribute__ ((packed));
> +} __packed;
>
> struct lbs_802_11d_domain_reg {
> /** Country code*/
> @@ -411,7 +411,7 @@ struct lbs_802_11d_domain_reg {
> /** No. of triplet*/
> u8 no_triplet;
> struct ieee80211_country_ie_triplet triplet[MRVDRV_MAX_TRIPLET_802_11D];
> -} __attribute__ ((packed));
> +} __packed;
>
> /*
> * Define data structure for CMD_GET_HW_SPEC
prev parent reply other threads:[~2010-07-21 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 14:37 [PATCH] libertas: convert new uses of __attribute__ ((packed)) to __packed John W. Linville
2010-07-21 19:58 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279742306.7267.4.camel@dcbw.foobar.com \
--to=dcbw@redhat.com \
--cc=akarwar@marvell.com \
--cc=holgerschurig@gmail.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).