From: Dan Williams <dcbw@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Holger Schurig <holgerschurig@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Amitkumar Karwar <akarwar@marvell.com>,
Stephen Hemminger <shemminger@vyatta.com>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] libertas: precedence bug
Date: Thu, 22 Jul 2010 15:24:54 -0700 [thread overview]
Message-ID: <1279837494.4829.18.camel@dcbw.foobar.com> (raw)
In-Reply-To: <20100722122102.GH17585@bicker>
On Thu, 2010-07-22 at 14:21 +0200, Dan Carpenter wrote:
> Negate has precedence over comparison so the original test was always
> false. (Neither 0 nor 1 are equal to NL80211_IFTYPE_MONITOR).
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> diff --git a/drivers/net/wireless/libertas/tx.c b/drivers/net/wireless/libertas/tx.c
> index 411a3bb..8000ca6 100644
> --- a/drivers/net/wireless/libertas/tx.c
> +++ b/drivers/net/wireless/libertas/tx.c
> @@ -180,7 +180,7 @@ void lbs_send_tx_feedback(struct lbs_private *priv, u32 try_count)
> {
> struct tx_radiotap_hdr *radiotap_hdr;
>
> - if (!priv->wdev->iftype == NL80211_IFTYPE_MONITOR ||
> + if (priv->wdev->iftype != NL80211_IFTYPE_MONITOR ||
> priv->currenttxskb == NULL)
> return;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-07-22 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 12:21 [patch -next] libertas: precedence bug Dan Carpenter
2010-07-22 22:24 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279837494.4829.18.camel@dcbw.foobar.com \
--to=dcbw@redhat.com \
--cc=akarwar@marvell.com \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=holgerschurig@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).