From: Pavel Roskin <proski@gnu.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, Daniel Drake <dsd@gentoo.org>,
Ulrich Kunitz <kune@deine-taler.de>
Subject: Re: [PATCH] zd1211rw: make CR_INTERRUPT cast explicit
Date: Fri, 23 Jul 2010 18:55:36 -0400 [thread overview]
Message-ID: <1279925736.23722.5.camel@mj> (raw)
In-Reply-To: <20100722190339.GD2616@tuxdriver.com>
On Thu, 2010-07-22 at 15:03 -0400, John W. Linville wrote:
> On Wed, Jul 21, 2010 at 12:36:58PM -0400, Pavel Roskin wrote:
> > I think __force should be used sparingly, especially outside headers. I
> > tried other ways to prevent the warning. I tried declaring int_num as
> > zd_addr_t, but sparse keeps complaining about the same comparison.
>
> Actually, it looks like it works w/o the "__force" as well.
> Any objection to a version like that?
Ideally, I would avoid any workarounds for sparse. The bug was
acknowledged by a sparse developer, so I expect it to be fixed.
http://www.spinics.net/lists/linux-sparse/msg02167.html
However, a version without __force would be more acceptable than a
version with __force.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2010-07-23 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 15:08 [PATCH] zd1211rw: make CR_INTERRUPT cast explicit John W. Linville
2010-07-21 16:36 ` Pavel Roskin
2010-07-22 19:03 ` John W. Linville
2010-07-23 22:55 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279925736.23722.5.camel@mj \
--to=proski@gnu.org \
--cc=dsd@gentoo.org \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).