From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: simplify key locking
Date: Mon, 26 Jul 2010 09:42:58 +0200 [thread overview]
Message-ID: <1280130178.3693.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100726013953.GA29386@jm.kir.nu>
On Sun, 2010-07-25 at 18:39 -0700, Jouni Malinen wrote:
> The following seems to be more or less minimal patch with that
> approach to get rid of this oops with FT protocol.. Is this what you
> were looking for?
Well so to answer both your emails :-)
> - ieee80211_key_disable_hw_accel(key);
> + if (key->local)
> + ieee80211_key_disable_hw_accel(key);
> - ieee80211_debugfs_key_remove(key);
> + if (key->local)
> + ieee80211_debugfs_key_remove(key);
These might look odd, but they're fine on a key that hasn't been used
since it couldn't have been uploaded to hardware, or put into debugfs,
so they'll just exit right away.
The rest of the patch is exactly what I was thinking of.
johannes
next prev parent reply other threads:[~2010-07-26 7:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 8:19 [PATCH] mac80211: simplify key locking Johannes Berg
2010-07-24 5:33 ` Jouni Malinen
2010-07-24 9:06 ` Johannes Berg
2010-07-26 1:04 ` Jouni Malinen
2010-07-26 1:39 ` Jouni Malinen
2010-07-26 7:42 ` Johannes Berg [this message]
2010-07-26 14:20 ` Jouni Malinen
2010-07-26 14:27 ` Johannes Berg
2010-07-26 22:52 ` [PATCH] mac80211: Fix key freeing to handle unlinked keys Jouni Malinen
2010-07-27 6:38 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280130178.3693.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).