From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] iwlwifi: abort scan when restarting
Date: Mon, 09 Aug 2010 19:06:53 +0200 [thread overview]
Message-ID: <1281373613.20185.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100809160203.GA22569@redhat.com>
On Mon, 2010-08-09 at 18:02 +0200, Stanislaw Gruszka wrote:
> iwl_scan_cancel_timeout() will not success if we are performing it
> from work handler, because workqueue can not fire new work when
> still other one is performed. To prevent such situation
> schedule priv->abort_scan to generic workqueue. Also increase
> sleep time to have better change abort_scan work complete.
I don't like this much, but you're right. However, I think we can get
around this by having iwl_scan_cancel_timeout() not call
iwl_scan_cancel() but rather do everything that iwl_bg_abort_scan()
would do directly, since _timeout() may sleep, while scan_cancel() may
not. What do you think?
johannes
next prev parent reply other threads:[~2010-08-09 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 16:02 [RFC PATCH] iwlwifi: abort scan when restarting Stanislaw Gruszka
2010-08-09 17:06 ` Johannes Berg [this message]
2010-08-10 6:57 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281373613.20185.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=sgruszka@redhat.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).