From: Johannes Berg <johannes@sipsolutions.net>
To: mbizon@freebox.fr
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: fix race between sysfs and cfg80211
Date: Mon, 16 Aug 2010 11:06:54 +0200 [thread overview]
Message-ID: <1281949614.3683.10.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1281767472.12446.551.camel@sakura.staff.proxad.net>
On Sat, 2010-08-14 at 08:31 +0200, Maxime Bizon wrote:
> The driver is still inside ieee80211_register_hw(), but the userspace is
> able to create the AP interface before the call is over. Once
> wiphy_register() is done, no lock seems to prevent this from happening.
>
> ieee80211_init_rate_ctrl_alg() then fails with EBUSY, and
> ieee80211_register_hw() starts unregistering the phy.
>
> Is that expected ?
Oops. No, not really, but I think the problem is that we do
wiphy_register far too early. I think we should see if we can reorder
the code in register_hw(). It won't be perfect wrt. debugfs, but I don't
think that is a problem.
johannes
prev parent reply other threads:[~2010-08-16 9:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-17 3:13 [RFC] cfg80211: fix race between sysfs and cfg80211 Maxime Bizon
2010-07-17 19:29 ` Johannes Berg
2010-07-17 22:24 ` Maxime Bizon
2010-07-20 23:07 ` Maxime Bizon
2010-07-21 15:21 ` [PATCH] " Maxime Bizon
2010-07-22 20:37 ` Luis R. Rodriguez
2010-07-23 2:29 ` [PATCH v2] " Maxime Bizon
2010-08-12 18:41 ` Maxime Bizon
2010-08-12 18:42 ` Johannes Berg
2010-08-14 6:31 ` Maxime Bizon
2010-08-16 9:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281949614.3683.10.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).