From: Joe Perches <joe@perches.com>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH] b43: N-PHY: add missing phyrxchain setting and fix warning in RX core function
Date: Sun, 22 Aug 2010 13:08:59 -0700 [thread overview]
Message-ID: <1282507739.1879.50.camel@Joe-Laptop> (raw)
In-Reply-To: <AANLkTikP5hQKMyJD1-7+gaY8PykQ77At+Vpkqf=HRT0H@mail.gmail.com>
On Sun, 2010-08-22 at 21:49 +0200, Gábor Stefanik wrote:
> 2010/8/22 Rafał Miłecki <zajec5@gmail.com>:
> > @@ -3103,7 +3105,7 @@ static void b43_nphy_set_rx_core_state(struct b43_wldev *dev, u8 mask)
> > b43_phy_maskset(dev, B43_NPHY_RFSEQCA, ~B43_NPHY_RFSEQCA_RXEN,
> > (mask & 0x3) << B43_NPHY_RFSEQCA_RXEN_SHIFT);
> >
> > - if (mask & 0x3 != 0x3) {
> > + if ((mask & 0x3) != 0x3) {
>
> Why is this needed? An & doesn't magically transform into an && under
> any circumstances...
For the same reason it's used in the b43_phy_maskset call.
Clarity.
prev parent reply other threads:[~2010-08-22 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 19:47 [PATCH] b43: N-PHY: add missing phyrxchain setting and fix warning in RX core function Rafał Miłecki
2010-08-22 19:49 ` Gábor Stefanik
2010-08-22 20:00 ` Rafał Miłecki
2010-08-22 20:08 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282507739.1879.50.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netrolller.3d@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox