From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless@vger.kernel.org,
Krishna Kumar <krkumar2@in.ibm.com>,
netdev@vger.kernel.org
Subject: Re: mac80211 using different tx queue for frames with same TID and RA
Date: Mon, 30 Aug 2010 16:11:20 +0200 [thread overview]
Message-ID: <1283177480.3691.66.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201008301601.12971.helmut.schaa@googlemail.com>
On Mon, 2010-08-30 at 16:01 +0200, Helmut Schaa wrote:
> while debugging an issue in rt2x00 I've discovered that in some cases frames
> with the same TID and RA end up in different tx queues (which causes problems
> in rt2x00 when using aggregation).
>
> Is this behavior expected and we need to handle that case in rt2x00 or is it
> more likely a bug? At least I thought the select_queue implementation in
> mac80211 was meant to always pick the same tx queue for skbs with the same
> priority and hence it shouldn't happen that frames with the same TID are
> queued into different tx queues.
Indeed, that seems like a bug. I don't see how this can happen though,
since the code _appears_ to not use the sk_tx_queue_mapping when an
ndo_select_queue method is present.
johannes
next prev parent reply other threads:[~2010-08-30 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 14:01 mac80211 using different tx queue for frames with same TID and RA Helmut Schaa
2010-08-30 14:11 ` Johannes Berg [this message]
2010-08-30 14:34 ` Helmut Schaa
2010-08-30 14:41 ` Johannes Berg
2010-08-30 14:50 ` Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283177480.3691.66.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=helmut.schaa@googlemail.com \
--cc=krkumar2@in.ibm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).