From: y@tuxdriver.com
To: linux-wireless@vger.kernel.org
Cc: me@bobcopeland.com, johannes@sipsolutions.net,
"John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH] ath5k: eliminate warning unintialized variable warning
Date: Mon, 30 Aug 2010 14:19:59 -0400 [thread overview]
Message-ID: <1283192399-3251-1-git-send-email-y> (raw)
In-Reply-To: <1283191913-3155-1-git-send-email-linville@tuxdriver.com>
From: John W. Linville <linville@tuxdriver.com>
ath5k/base.c:1317: warning: ‘ret’ may be used uninitialized in this function
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
Actually include patch this time...
drivers/net/wireless/ath/ath5k/base.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 7139c7e..116ac66 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -1327,8 +1327,10 @@ ath5k_txbuf_setup(struct ath5k_softc *sc, struct ath5k_buf *bf,
PCI_DMA_TODEVICE);
rate = ieee80211_get_tx_rate(sc->hw, info);
- if (!rate)
+ if (!rate) {
+ ret = -EINVAL;
goto err_unmap;
+ }
if (info->flags & IEEE80211_TX_CTL_NO_ACK)
flags |= AR5K_TXDESC_NOACK;
--
1.7.2.2
next prev parent reply other threads:[~2010-08-30 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 18:11 [PATCH] ath5k: eliminate warning unintialized variable warning John W. Linville
2010-08-30 18:19 ` y [this message]
2010-08-30 18:21 ` John W. Linville
2010-08-30 18:42 ` me
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283192399-3251-1-git-send-email-y \
--to=y@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox