From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: cancel scan in ieee80211_restart_hw
Date: Tue, 31 Aug 2010 11:29:41 +0200 [thread overview]
Message-ID: <1283246981.3733.7.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100830193701.GF30864@tuxdriver.com>
On Mon, 2010-08-30 at 15:37 -0400, John W. Linville wrote:
> > > - /* use this reason, __ieee80211_resume will unblock it */
> > > + ieee80211_scan_cancel(local);
> > > +
> > > + /* use this reason, ieee80211_reconfig will unblock it */
> >
> > Hmm, yes .. but how will this interact with hw scan?
>
> You tell me -- I would think that calling ieee80211_restart_hw
> would effectively abandon all hope of a hardware scan completing.
> Should the caller call ieee80211_scan_completed(..., 1)? Or should
> we do that (or equivalent) here too?
Yeah, I guess the caller probably should since it may have internal
state that needs resetting for scans as well. Maybe we should
WARN_ON(scan in progress) here for the hw scan case, and do what you're
proposing only for SW scan?
johannes
next prev parent reply other threads:[~2010-08-31 9:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 19:14 [PATCH] mac80211: cancel scan in ieee80211_restart_hw John W. Linville
2010-08-30 19:17 ` Johannes Berg
2010-08-30 19:37 ` John W. Linville
2010-08-31 9:29 ` Johannes Berg [this message]
2010-08-31 19:25 ` [PATCH] mac80211: cancel scan in ieee80211_restart_hw if software scan pending John W. Linville
2010-09-01 10:29 ` Johannes Berg
2010-09-01 18:58 ` John W. Linville
2010-09-01 19:02 ` John W. Linville
2010-09-01 19:10 ` Johannes Berg
2010-09-01 20:17 ` John W. Linville
2010-09-02 8:29 ` Johannes Berg
2010-09-01 20:17 ` [PATCH] mac80211: only cancel software-based scans on suspend John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283246981.3733.7.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).