From: Johannes Berg <johannes@sipsolutions.net>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: Rajkumar Manoharan <Rajkumar.Manoharan@Atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>
Subject: Re: [RFC] mac80211: avoid recalc_idle in monitor mode
Date: Wed, 15 Sep 2010 15:05:26 +0200 [thread overview]
Message-ID: <1284555926.7705.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100915130526.GA18627@vmraj-lnx.users.atheros.com>
On Wed, 2010-09-15 at 18:35 +0530, Rajkumar Manoharan wrote:
> > > - mutex_lock(&local->mtx);
> > > - hw_reconf_flags |= __ieee80211_recalc_idle(local);
> > > - mutex_unlock(&local->mtx);
> > > + if (sdata->vif.type != NL80211_IFTYPE_MONITOR) {
> > > + mutex_lock(&local->mtx);
> > > + hw_reconf_flags |= __ieee80211_recalc_idle(local);
> > > + mutex_unlock(&local->mtx);
> > > + }
> >
> > Hmm, that doesn't seem right, wouldn't it be idle to start with?
> not sure whether I am missing something here. Shouldn't we be receiving frames
> in monitor mode as soon as the interface is up and running. I don't see any
> reason why should we even care about IDLE state for MONITOR mode.
But if the device is already idle, adding the monitor wouldn't change it
either, which seems wrong, no?
johannes
prev parent reply other threads:[~2010-09-15 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 11:56 [RFC] mac80211: avoid recalc_idle in monitor mode Rajkumar Manoharan
2010-09-15 12:12 ` Johannes Berg
2010-09-15 13:05 ` Rajkumar Manoharan
2010-09-15 13:05 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284555926.7705.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Rajkumar.Manoharan@Atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).