From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>
Subject: Re: [PATCH 2/2] mac80211: add p2p device type support
Date: Thu, 16 Sep 2010 20:42:18 +0200 [thread overview]
Message-ID: <1284662538.3731.12.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AANLkTikxcSXgEA-zM250AZ2v4sJk_U-gf2sjSoJ2x4ZR@mail.gmail.com>
On Thu, 2010-09-16 at 11:40 -0700, Luis R. Rodriguez wrote:
> >> While at it can you add a is_beaconing_iftype() or something, that
> >> should reduce code and make it easier to check for these modes.
> >
> > Err, it doesn't really change for drivers, since it's still AP/IBSS --
> > since GO is just an AP subtype internally.
>
> Well if the iftype is a beaconing one it used to use AP interface type
> before and now its a GO then yeah I could see this requiring changes
> in drivers. Apart from the filter stuff ath9k does have some checks
> for current operating interface type IIRC.
But nothing changes for it -- look at the patch again, I translate
P2P_GO to AP and P2P_CLIENT to STATION precisely to require fewer
changes in drivers unless they actually want to care. The only ath9k
change that is required is the one I posted (and you'll be back to the
same non-functioning state, but that's another matter).
johannes
next prev parent reply other threads:[~2010-09-16 18:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 12:58 [PATCH 0/2] p2p interface types Johannes Berg
2010-09-16 12:58 ` [PATCH 1/2] cfg80211/nl80211: introduce p2p device types Johannes Berg
2010-09-16 12:58 ` [PATCH 2/2] mac80211: add p2p device type support Johannes Berg
2010-09-16 18:22 ` Luis R. Rodriguez
2010-09-16 18:30 ` Johannes Berg
2010-09-16 18:40 ` Luis R. Rodriguez
2010-09-16 18:42 ` Johannes Berg [this message]
2010-09-16 18:56 ` Luis R. Rodriguez
2010-09-16 13:20 ` [RFC] ath9k: advertise support for p2p Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284662538.3731.12.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).