From: Felix <ic.felix@gmail.com>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] carl9170: update AR9170 phy initvals
Date: Mon, 20 Sep 2010 09:12:06 -0700 [thread overview]
Message-ID: <1284999126.5753.47.camel@darkslate> (raw)
In-Reply-To: <201009162255.21158.chunkeey@googlemail.com>
On Thu, 2010-09-16 at 22:55 +0200, Christian Lamparter wrote:
> This patch is loosely based on an ath9k patch called:
> "ath9k_hw: sync initvals for ar9001 and ar9002 with Atheros"
>
> It includes the following changes/fixes:
> - AGC setting improvements
> - timing changes for improved performance
>
> Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
> ---
> To begin with: The initvals of AR9160(pci) are slightly
> different than those from AR9170(usb). It would be nice
> to know if the changes are implemented correctly, or not.
Yes the changes are implemented correctly.
The modified values are all for registers that are identical in AR9160
and AR9170.
> ---
> diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c
> index 47709c1..71dea97 100644
> --- a/drivers/net/wireless/ath/carl9170/phy.c
> +++ b/drivers/net/wireless/ath/carl9170/phy.c
> @@ -85,11 +85,12 @@ static struct carl9170_phy_init ar5416_phy_init[] = {
> { 0x1c5844, 0x1372161e, 0x13721c1e, 0x13721c24, 0x137216a4, },
> { 0x1c5848, 0x001a6a65, 0x001a6a65, 0x00197a68, 0x00197a68, },
> { 0x1c584c, 0x1284233c, 0x1284233c, 0x1284233c, 0x1284233c, },
> - { 0x1c5850, 0x6c48b4e4, 0x6c48b4e4, 0x6c48b0e4, 0x6c48b0e4, },
> + { 0x1c5850, 0x6c48b4e4, 0x6d48b4e4, 0x6d48b0e4, 0x6c48b0e4, },
This reg (0x9850) is identical for AR9160 and AR9170. The changes have
the same effect on both generations.
> { 0x1c5854, 0x00000859, 0x00000859, 0x00000859, 0x00000859, },
> { 0x1c5858, 0x7ec80d2e, 0x7ec80d2e, 0x7ec80d2e, 0x7ec80d2e, },
> - { 0x1c585c, 0x31395c5e, 0x31395c5e, 0x31395c5e, 0x31395c5e, },
> + { 0x1c585c, 0x31395c5e, 0x3139605e, 0x3139605e, 0x31395c5e, },
This reg (0x985c) is identical for AR9160 and AR9170. The changes have
the same effect on both generations.
> { 0x1c5860, 0x0004dd10, 0x0004dd10, 0x0004dd20, 0x0004dd20, },
> + { 0x1c5864, 0x0001c600, 0x0001c600, 0x0001c600, 0x0001c600, },
This reg (0x9864) is identical for AR9160 and AR9170. The changes have
the same effect on both generations.
This will write the default value, perhaps restore it if it got changed,
perhaps by ani.
> { 0x1c5868, 0x409a4190, 0x409a4190, 0x409a4190, 0x409a4190, },
> { 0x1c586c, 0x050cb081, 0x050cb081, 0x050cb081, 0x050cb081, },
> { 0x1c5900, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
> @@ -131,9 +132,10 @@ static struct carl9170_phy_init ar5416_phy_init[] = {
> { 0x1c59ac, 0x006f00c4, 0x006f00c4, 0x006f00c4, 0x006f00c4, },
> { 0x1c59b0, 0x03051000, 0x03051000, 0x03051000, 0x03051000, },
> { 0x1c59b4, 0x00000820, 0x00000820, 0x00000820, 0x00000820, },
> + { 0x1c59bc, 0x00181400, 0x00181400, 0x00181400, 0x00181400, },
This reg (0x99bc) is identical for AR9160 and AR9170. The changes have
the same effect on both generations. Extension channel version of
(0x5864).
> { 0x1c59c0, 0x038919be, 0x038919be, 0x038919be, 0x038919be, },
> { 0x1c59c4, 0x06336f77, 0x06336f77, 0x06336f77, 0x06336f77, },
> - { 0x1c59c8, 0x60f6532c, 0x60f6532c, 0x60f6532c, 0x60f6532c, },
> + { 0x1c59c8, 0x6af6532c, 0x6af6532c, 0x6af6532c, 0x6af6532c, },
This reg (0x99c8) is identical for AR9160 and AR9170. The changes have
the same effect on both generations.
Increases threshold for flagging external channel as stronger than
primary channel from 0dB to 10dB.
> { 0x1c59cc, 0x08f186c8, 0x08f186c8, 0x08f186c8, 0x08f186c8, },
> { 0x1c59d0, 0x00046384, 0x00046384, 0x00046384, 0x00046384, },
> { 0x1c59d4, 0x00000000, 0x00000000, 0x00000000, 0x00000000, },
Apologies for the delay ;-)
Felix
prev parent reply other threads:[~2010-09-20 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 20:55 [PATCH] carl9170: update AR9170 phy initvals Christian Lamparter
2010-09-20 16:12 ` Felix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284999126.5753.47.camel@darkslate \
--to=ic.felix@gmail.com \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).