From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [mac80211] mac80211: Support receiving data frames on multiple vifs.
Date: Tue, 21 Sep 2010 08:32:18 +0200 [thread overview]
Message-ID: <1285050738.3710.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4C97BC5E.5060704@candelatech.com>
On Mon, 2010-09-20 at 12:56 -0700, Ben Greear wrote:
> On 09/20/2010 12:10 PM, Johannes Berg wrote:
> > On Mon, 2010-09-20 at 10:52 -0700, greearb@candelatech.com wrote:
> >> From: Ben Greear<greearb@candelatech.com>
> >>
> >> When using multiple STA interfaces on the same radio, some
> >> data packets need to be received on all interfaces
> >> (broadcast, for instance).
> >>
> >> Remove special loop for data-only packets and just process all
> >> packets in the big loop that previously only handled non-data
> >> packets.
> >
> > I'd prefer keeping different for_each_*, but maybe we can make the loops
> > just call a common function, say with&prev pointer or something? The
> > station loop will typically be iterating over fewer things here.
>
> While attempting this, I see something strange. It appears that
> for the last interface (in the non-data loop), the
> if (status->flag & RX_FLAG_MMIC_ERROR)
> logic will not be run?
>
> Is that on purpose?
No, certainly not.
johannes
next prev parent reply other threads:[~2010-09-21 6:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 17:52 [mac80211] mac80211: Support receiving data frames on multiple vifs greearb
2010-09-20 19:10 ` Johannes Berg
2010-09-20 19:56 ` Ben Greear
2010-09-21 6:32 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-20 21:39 greearb
2010-09-21 6:47 ` Johannes Berg
2010-09-23 13:57 ` Ben Greear
2010-09-23 14:06 ` Johannes Berg
2010-09-23 16:57 ` Ben Greear
2010-09-23 18:42 ` Johannes Berg
2010-09-23 18:48 ` Ben Greear
2010-09-23 19:07 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285050738.3710.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).