From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [mac80211/ath9k] mac80211/ath9k: Support AMPDU with multiple VIFs.
Date: Tue, 21 Sep 2010 21:07:28 +0200 [thread overview]
Message-ID: <1285096048.12764.9.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1285095455-29081-1-git-send-email-greearb@candelatech.com>
On Tue, 2010-09-21 at 11:57 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> The old ieee80211_find_sta_by_hw method didn't properly
> find VIFS when there was more than on per AP. This caused
> AMPDU logic in ath9k to get the wrong VIF when trying to
> account for transmitted SKBs.
>
> This patch changes ieee80211_find_sta_by_hw to take a
> net_device pointer to distinguish among multiple VIFs.
Err, no, this certainly isn't the right thing to do, is skb->dev even
guaranteed to be right? I'm not convinced of that, and besides, if you
can have the dev you can have the vif too.
johannes
next prev parent reply other threads:[~2010-09-21 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 18:57 [mac80211/ath9k] mac80211/ath9k: Support AMPDU with multiple VIFs greearb
2010-09-21 19:07 ` Johannes Berg [this message]
2010-09-21 19:17 ` Ben Greear
2010-09-21 19:19 ` Johannes Berg
2010-09-21 19:29 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285096048.12764.9.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).