From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:46811 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803Ab0IVKBW (ORCPT ); Wed, 22 Sep 2010 06:01:22 -0400 Subject: Re: pull request: wireless-next-2.6 2010-09-21 From: Johannes Berg To: Christian Lamparter Cc: David Miller , linville@tuxdriver.com, linux-wireless@vger.kernel.org In-Reply-To: <201009221158.13806.chunkeey@googlemail.com> References: <20100921201705.GC2448@tuxdriver.com> <20100921.183614.245388137.davem@davemloft.net> <201009221158.13806.chunkeey@googlemail.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 22 Sep 2010 12:01:17 +0200 Message-ID: <1285149677.3684.12.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2010-09-22 at 11:58 +0200, Christian Lamparter wrote: > On Wednesday 22 September 2010 03:36:14 David Miller wrote: > > From: "John W. Linville" > > Date: Tue, 21 Sep 2010 16:17:05 -0400 > > > > Pulled, but I suspect the 'packed' attribute usage is wrong in > > ath/carl9170 and can just be deleted. > > which __packed do you think can be removed? Well, there are bitfields in packed structs, which is either completely wrong (think endianness ... never use them to interface with something outside your own CPU), or needn't be packed. johannes