From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net
Subject: Re: [PATCH wireless-2.6] iwlwifi: do not perferm force reset while doing scan
Date: Wed, 22 Sep 2010 16:39:57 +0200 [thread overview]
Message-ID: <1285166397.3684.64.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100922105722.3be42969@dhcp-lab-109.englab.brq.redhat.com>
On Wed, 2010-09-22 at 10:57 +0200, Stanislaw Gruszka wrote:
> So why we can see this warning? During my testing I saw it also.
> There is race regarding SCAN_HW_SCANNING bit, usually we set/clear
> this bit under local->mtx, but not in ieee80211_restart_hw()
>
> cpu0 cpu1
> __ieee80211_start_scan
> __set_bit(SCAN_HW_SCANNING, &local->scanning);
>
> iwl_bg_restart()
> ieee80211_restart_hw()
> WARN
Why can't iwlwifi's bg_restart() force-abort the scan? It'll be aborted
anyway...
johannes
next prev parent reply other threads:[~2010-09-22 14:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 21:24 [PATCH wireless-2.6] iwlwifi: do not perferm force reset while doing scan Wey-Yi Guy
2010-09-22 8:57 ` Stanislaw Gruszka
2010-09-22 14:33 ` Guy, Wey-Yi
2010-09-22 14:39 ` Johannes Berg [this message]
2010-09-22 14:51 ` Stanislaw Gruszka
2010-09-22 15:10 ` Johannes Berg
2010-09-22 15:23 ` Stanislaw Gruszka
2010-09-22 15:27 ` Johannes Berg
2010-09-22 15:29 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285166397.3684.64.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).