linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ipw3945-devel@lists.sourceforge.net"
	<ipw3945-devel@lists.sourceforge.net>
Subject: Re: [PATCH wireless-2.6] iwlwifi: do not perferm force reset while doing scan
Date: Wed, 22 Sep 2010 08:29:02 -0700	[thread overview]
Message-ID: <1285169342.13944.12.camel@wwguy-ubuntu> (raw)
In-Reply-To: <20100922172353.3e53d221@dhcp-lab-109.englab.brq.redhat.com>

On Wed, 2010-09-22 at 08:23 -0700, Stanislaw Gruszka wrote:
> On Wed, 22 Sep 2010 17:10:57 +0200
> Johannes Berg <johannes@sipsolutions.net> wrote:
> 
> > On Wed, 2010-09-22 at 16:51 +0200, Stanislaw Gruszka wrote:
> > 
> > > Yes, bg_restart() force scan abort, but not if no scan is pending. It looks
> > > like that:
> > > 
> > > cpu0						cpu1
> > > 
> > > 						iwl_bg_restart()
> > > 						  __iwl_down()
> > > 						     iwl_scan_cancel_timeout
> > > 						     (do nothing since no pending scan)
> > > 			  
> > > __ieee80211_start_scan
> > >   __set_bit(SCAN_HW_SCANNING, &local->scanning);
> > 
> > Ah, ok, makes sense. I think some mutex trickery could possibly help
> > here though? But I'm not sure it's worth it...
> 
> I showed possible patch earlier in this thread, I will rethink about it and
> eventually post. Perhaps applying the patch is good idea, since we will stop
> seeing the warning it that harmless case, and be sure something is really
> wrong when see it again.
> 

I will prefer not seeing "warning" even it is harmless in this case

Thanks
Wey


      parent reply	other threads:[~2010-09-22 15:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-17 21:24 [PATCH wireless-2.6] iwlwifi: do not perferm force reset while doing scan Wey-Yi Guy
2010-09-22  8:57 ` Stanislaw Gruszka
2010-09-22 14:33   ` Guy, Wey-Yi
2010-09-22 14:39   ` Johannes Berg
2010-09-22 14:51     ` Stanislaw Gruszka
2010-09-22 15:10       ` Johannes Berg
2010-09-22 15:23         ` Stanislaw Gruszka
2010-09-22 15:27           ` Johannes Berg
2010-09-22 15:29           ` Guy, Wey-Yi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285169342.13944.12.camel@wwguy-ubuntu \
    --to=wey-yi.w.guy@intel.com \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).