linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [mac80211] mac80211:  Support multiple VIFS per AP in debugfs.
Date: Thu, 23 Sep 2010 10:30:39 +0200	[thread overview]
Message-ID: <1285230639.3691.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4C9A5CEB.9010708@candelatech.com>

On Wed, 2010-09-22 at 12:45 -0700, Ben Greear wrote:

> This look better?
> 
> diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c
> index e81ef4e..ebd5b69 100644
> --- a/net/mac80211/debugfs.c
> +++ b/net/mac80211/debugfs.c
> @@ -368,7 +368,6 @@ void debugfs_hw_add(struct ieee80211_local *local)
>          if (!phyd)
>                  return;
> 
> -       local->debugfs.stations = debugfs_create_dir("stations", phyd);
>          local->debugfs.keys = debugfs_create_dir("keys", phyd);
> 
>          DEBUGFS_ADD(frequency);

Yeah, but completely whitespace damaged, you're going to have to work on
your submissions :)

Also, why do you do "[mac80211] mac80211" rather than "[PATCH]
mac80211"?

johannes


  reply	other threads:[~2010-09-23  8:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 12:15 [mac80211] mac80211: Support multiple VIFS per AP in debugfs greearb
2010-09-21 16:25 ` Ben Greear
2010-09-21 16:30   ` Johannes Berg
2010-09-21 16:42     ` Ben Greear
2010-09-21 17:03       ` Johannes Berg
2010-09-21 17:49         ` Johannes Berg
2010-09-21 18:02           ` Ben Greear
2010-09-22 16:59           ` Ben Greear
2010-09-22 17:01             ` Johannes Berg
2010-09-22 17:34               ` Ben Greear
2010-09-22 18:31                 ` Johannes Berg
2010-09-22 18:48                   ` John W. Linville
2010-09-22 19:45                     ` Ben Greear
2010-09-23  8:30                       ` Johannes Berg [this message]
2010-09-23 13:12                         ` Ben Greear
  -- strict thread matches above, loose matches on Subject: below --
2010-09-23  3:29 greearb
2010-09-23  8:36 ` Johannes Berg
2010-10-16 19:00   ` Christian Lamparter
2010-10-18 20:05     ` Ben Greear
     [not found]     ` <4CDAF182.4030409@candelatech.com>
2010-11-10 20:01       ` Christian Lamparter
2010-09-21  4:21 greearb
2010-09-21  6:48 ` Johannes Berg
2010-09-21 12:04   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285230639.3691.1.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).