linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luciano Coelho <luciano.coelho@nokia.com>
To: "balbi@ti.com" <balbi@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Ohad Ben-Cohen <ohad@wizery.com>
Subject: Re: [PATCH v2] omap: beagle: add support for wl1271 on the board file
Date: Thu, 23 Sep 2010 15:28:28 +0300	[thread overview]
Message-ID: <1285244908.3231.77.camel@chilepepper> (raw)
In-Reply-To: <20100923122048.GO4580@legolas.emea.dhcp.ti.com>

On Thu, 2010-09-23 at 14:20 +0200, ext Felipe Balbi wrote:
> Hi Luca,
> 
> On Thu, Sep 23, 2010 at 07:17:33AM -0500, Luciano Coelho wrote:
> >On Thu, 2010-09-23 at 13:45 +0200, ext Felipe Balbi wrote:
> >> On Thu, Sep 23, 2010 at 03:20:03AM -0500, Luciano Coelho wrote:
> >> > static struct mtd_partition omap3beagle_nand_partitions[] = {
> >> >@@ -163,12 +168,25 @@ static void __init beagle_display_init(void)
> >> >
> >> > #include "sdram-micron-mt46h32m32lf-6.h"
> >> >
> >> >+struct wl12xx_platform_data omap_beagle_wlan_data __initdata = {
> >> >+	.irq = OMAP_GPIO_IRQ(OMAP_BEAGLE_WLAN_IRQ_GPIO),
> >>
> >> can you pass IRQ as a struct resource ?
> >
> >Sorry, I don't understand what you mean here.  Can you clarify?
> 
> static struct resource wl12xx_resource[] = {
> 	{
> 		.start	= OMAP_GPIO_IRQ(OMAP_BEAGLE_WLAN_IRQ_GPIO),
> 		.flags	= IORESOURCE_IRQ,
> 	},
> };
> 
> static struct platform_device wl12xx_platform_device = {
> 	.resource	= wl12xx_resource,
> 	.num_resources	= ARRAY_SIZE(wl12xx_resource),
> 	.....
> };
> 
> then on driver you would:
> 
> irq = platform_get_irq(pdev, 0);
> 
> something like that :-)

Ah, I see.  Thanks for the explanation.  I guess we could do that in a
separate patch.  The zoom board file already uses this .irq element, so
this patch would not be the appropriate place to change it.

Is it okay if I deal with that after I'm done with the current patch?


  reply	other threads:[~2010-09-23 12:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-23  8:20 [PATCH v2] omap: beagle: add support for wl1271 on the board file Luciano Coelho
2010-09-23 10:30 ` Grazvydas Ignotas
2010-09-23 11:56   ` Luciano Coelho
2010-09-23 12:03   ` Robert Nelson
2010-09-23 12:52     ` Luciano Coelho
2010-09-23 13:42       ` Robert Nelson
2010-09-23 18:52         ` Luciano Coelho
2010-09-23 11:45 ` Felipe Balbi
2010-09-23 12:17   ` Luciano Coelho
2010-09-23 12:20     ` Felipe Balbi
2010-09-23 12:28       ` Luciano Coelho [this message]
2010-09-23 12:29         ` Felipe Balbi
2010-09-23 12:46       ` Ohad Ben-Cohen
2010-09-23 12:50         ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285244908.3231.77.camel@chilepepper \
    --to=luciano.coelho@nokia.com \
    --cc=balbi@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).