From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [wireless] wireless: Keep phy name consistent across module reloads.
Date: Fri, 24 Sep 2010 23:18:54 +0200 [thread overview]
Message-ID: <1285363135.11036.7.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4C9D13AC.4080308@candelatech.com>
On Fri, 2010-09-24 at 14:10 -0700, Ben Greear wrote:
> > We cannot do this because otherwise operations you attempt to do one one
> > PHY will race with re-creating of the same phy index. For the same
> > reason, interface indexes aren't reused for netdevs.
> >
> > If this bothers you so much, you can easily write a udev rule that
> > renames all your phys to "myphy" or whatever.
>
> Sorry about that.
>
> Would a similar patch be acceptable that just set the name to the first
> available phyX, but left the index to increment monotomically as it does
> now be OK?
Actually, right now it doesn't even allow you to use a "phy%d" name,
which is because I don't want (sysfs, debugfs) errors coming from doing
"iw phy0 set name phy1" and then plugging in a new device ... In doing
that, I manage to avoid having to allocate two different numbers...
I suppose it'd be possible to treat this more like interfaces. Want to
also make it per net namespace? ;-)
> I'd really like to not have to deal with udev if possible!
It's really not very hard, you just need a rule that reacts to adding a
new phy, and calls "iw phy#7 set name myphy" :-)
johannes
next prev parent reply other threads:[~2010-09-24 21:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 23:57 [wireless] wireless: Keep phy name consistent across module reloads greearb
2010-09-24 21:02 ` Johannes Berg
2010-09-24 21:10 ` Ben Greear
2010-09-24 21:18 ` Johannes Berg [this message]
2010-09-24 21:25 ` Ben Greear
2010-09-24 21:31 ` Johannes Berg
2010-09-24 21:33 ` Ben Greear
2010-09-24 22:21 ` Ben Greear
2010-09-24 22:25 ` Johannes Berg
2010-09-24 22:37 ` Ben Greear
2010-09-27 20:41 ` wireless-next-2.6 rebased -- " John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285363135.11036.7.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).